Skip to content

Stop broad objective completion rejection loops#430

Open
nathanwhit wants to merge 1 commit into
mainfrom
codex/replan-completion-loop-guard
Open

Stop broad objective completion rejection loops#430
nathanwhit wants to merge 1 commit into
mainfrom
codex/replan-completion-loop-guard

Conversation

@nathanwhit

Copy link
Copy Markdown
Owner

Summary

  • ignore review/evaluator gate worker results when checking for unpublished implementation candidates before finishing broad objectives
  • add a repeated completion-rejection brake so backend guards cannot keep invoking the replanner forever on the same blocked finish decision
  • cover both the stale code-review-gate candidate diff case and the repeated broad-objective rejection loop with tests

Validation

  • go test ./internal/orchestrator -run 'TestService(AllowsBroadObjectiveFinishWithReviewGateCandidateDiff|PausesRepeatedBroadObjectiveCompletionRejection|RejectsBroadObjectiveFinishWithUnpublishedCandidate|RejectsBroadObjectiveCompletionWithIncompleteWorkPlan)$'
  • go test ./internal/orchestrator ./internal/eventstore
  • go test ./internal/orchestrator -run 'TestService(AllowsBroadObjectiveFinishWithReviewGateCandidateDiff|PausesRepeatedBroadObjectiveCompletionRejection)$' -count=20

Ignore review/evaluator gate worker results when checking for unpublished implementation candidates before finishing a broad objective. Add a repeated backend completion-rejection brake so a broad objective pauses for steering instead of repeatedly invoking the replanner on the same blocked finish decision. Harden the dynamic spawned-worker concurrency test so CI load does not expire the assertion before replanning reaches the spawned workers.
@nathanwhit nathanwhit force-pushed the codex/replan-completion-loop-guard branch from 7b6704f to 5aee3c0 Compare June 11, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant