Skip to content

fixed angular path resolution issue - #96

Merged
jpike88 merged 2 commits into
nathansbradshaw:mainfrom
jpike88:main
Aug 2, 2026
Merged

fixed angular path resolution issue#96
jpike88 merged 2 commits into
nathansbradshaw:mainfrom
jpike88:main

Conversation

@jpike88

@jpike88 jpike88 commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

fixes #95

Also, uses the found angular srever path and auto-attempts to resolve the typescript package upwads from there.

Also readme is updated to be a bit more clear. I used Claude Opus 5, and have carefully proof read the output.

@nathansbradshaw please merge! Thanks mate

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Angular Zed extension to resolve the Angular language server (and probe locations for TypeScript) relative to the active worktree root, addressing Windows path resolution failures reported in #95.

Changes:

  • Resolve @angular/language-server from the worktree root (with an optional user override) and adjust probe locations used by the language server.
  • Pass worktree shell environment to the spawned Node process and add default console logging flags.
  • Update README with clearer requirements/configuration guidance and bump extension/package version to 0.0.7.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/angular.rs Reworks server path/probe resolution to be worktree-relative, adds settings for server path override and memory, and adjusts command env/args.
README.md Documents requirements, configuration options, troubleshooting, and version guidance.
extension.toml Bumps extension version to 0.0.7.
Cargo.toml Bumps crate version to 0.0.7.
Cargo.lock Updates lockfile version entry for the crate.
Suppressed comments (1)

README.md:132

  • This troubleshooting note repeats the hard "outside the supported range" claim for versions above 6.0.3, but the extension doesn’t validate TypeScript versions. Rephrasing to "untested" avoids implying an enforced check.
- **TypeScript resolution errors.** Check your installed TypeScript version with `npx tsc --version` — anything above 6.0.3 is outside the supported range.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/angular.rs
Comment thread README.md
Comment thread src/angular.rs Outdated
Comment thread src/angular.rs Outdated
Comment thread README.md Outdated
@nathansbradshaw

Copy link
Copy Markdown
Owner

I think copilot has some valid opinions, do you think we could fix or test on windows before this gets merged?

@nathansbradshaw

Copy link
Copy Markdown
Owner

@jpike88 do you have a way to test for windows?

@jpike88

jpike88 commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator Author

I've fired up an ec2 instance of windows server 2025 to test on, will let you know if my testing works, just need 20 mins

@jpike88

jpike88 commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator Author

works on Windows for me.

@guyhirsch

Copy link
Copy Markdown

@nathansbradshaw Looks good to me. I tested the changes locally, and they fixed the issue on my end. If you're happy with it as well, I think it's ready to merge. Thanks!

@jpike88
jpike88 merged commit b2e68e9 into nathansbradshaw:main Aug 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Angular extension 0.0.6 cannot find locally installed @angular/language-server on Windows

4 participants