Conversation
…eback rate limiting
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
========================================
Coverage 99.64% 99.65%
========================================
Files 236 239 +3
Lines 6512 6918 +406
Branches 1909 2082 +173
========================================
+ Hits 6489 6894 +405
- Misses 21 22 +1
Partials 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| * | ||
| * @returns {Promise<void>} Resolves after matching local audit documents are deleted. | ||
| */ | ||
| const clearAuditRowsForCollection = async () => { |
There was a problem hiding this comment.
can we make this at a higher scope its getting remade in various of the local tests
There was a problem hiding this comment.
Good call. I moved this into a shared local smoke-test helper and updated the callers.
| await closeDocumentDbClient() | ||
| await getDocumentDbClient() | ||
|
|
||
| expect(close).toHaveBeenCalledOnce() |
There was a problem hiding this comment.
this one only gets called once since the conn didn't exist in the first call?
There was a problem hiding this comment.
Correct. The initial close is intentionally a no-op because no connection exists yet. The test then verifies that closing an existing connection resets it, allowing the next call to create a new client.
| test('returns the expected ISO19115 payload shape when corrections are provided', async () => { | ||
| const mockPayload = ` | ||
| <gmi:MI_Metadata xmlns:gmd="http://www.isotc211.org/2005/gmd" xmlns:gco="http://www.isotc211.org/2005/gco"> | ||
| <gmi:MI_Metadata xmlns:gmi="http://www.isotc211.org/2005/gmi" xmlns:gmd="http://www.isotc211.org/2005/gmd" xmlns:gco="http://www.isotc211.org/2005/gco"> |
There was a problem hiding this comment.
this is for that error we'd seen on ISO where the longname was getting appended on a shortname update right?
There was a problem hiding this comment.
This is separate from the ShortName/LongName issue. The fixture already used gmi:MI_Metadata but did not declare the gmi namespace, so the XML was invalid; the @xmldom/xmldom upgrade exposed it, and this adds the missing namespace declaration.
4 participants
Overview
What is the feature?
Move metadata-correction auditing from RDF4J to Amazon DocumentDB Serverless. Each collection
correction is stored as one audit document with its current status, history, correction details,
and CMR revision IDs. Existing RDF4J audit history will not be migrated.
What is the Solution?
deployment-managed indexes.
checked,pending, andappliedorfailedstates.What areas of the application does this impact?
Testing
Reproduction steps
/metadata_correction_audit?format=htmland confirm the audit log shows the collection ID,status, and expected old-to-new keyword path.
revision IDs, and a readable native metadata diff.
Checklist