Repository navigation
Conversation
…ceCopy functions
…sa/gunns into 80-gunnsdraw-regression-tests
| with: | ||
| ref: 80-gunnsdraw-regression-tests |
There was a problem hiding this comment.
IMPORTANT: remove these two lines before merging
|
|
||
| # Force copy test files to truth_output | ||
| cp -aT test_files/netexport/nominal/ truth_output/ | ||
| cp -aT test_files/netexport/off_nominal/ truth_output/ |
There was a problem hiding this comment.
just a preference thing: could we have the comparison directories be named as follows?
output -> output_actual
truth_output ->output_expect
There was a problem hiding this comment.
should we git-track the .bak files?
There was a problem hiding this comment.
I would say no, though I could easily see someone accidentally committing them in the future. I suppose I could also check that the .bak files match the original file, as intended?
| echo "====== Off Nominal Tests =========================================================================" | ||
| for network in "${off_nominal[@]}" | ||
| do | ||
| coverage run -a ../netexport.py output/$network.xml 2>&1 | tee output/${network}_output.txt |
There was a problem hiding this comment.
i get an error for ./testNetExport.sh: line 71: coverage: command not found
what do I need to install in my Linux container for coverage?
There was a problem hiding this comment.
I'd run these, which I had to put in the test .yml as well:
python3 -m pip install --upgrade pip
pip install coverage
There was a problem hiding this comment.
I can add a check for that package in the test script
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| all_unit_tests: |
There was a problem hiding this comment.
could you choose a new job name?
|
@n-trevino -- Good test design, thorough, and already running in the pipeline. Love it. Great job! |
2 participants
See #80