feat(contrib): cache resampled trajectory and store options - #100
Open
reginaldalfret wants to merge 1 commit into
Open
reginaldalfret wants to merge 1 commit into
reginaldalfret wants to merge 1 commit into
Conversation
Store resample options on resampled TrajectoryAnalysis instances and cache results by options to avoid redundant calculations when called repeatedly with the same arguments. Closes nasa#66 Signed-off-by: reginaldalfret <reginaldalfret@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #66 by storing resample options on resampled
TrajectoryAnalysisinstances and caching the resampled instances in an internal_resample_cachedictionary on the original simulation instance.Details
(dt, include_output, include_events, max_deg)onself._resample_cache.resample()with the same options, returns the cached instance immediately to skip redundant spline fitting, evaluations, and dynamic output recalculations.original_instance.resample(...)checks the original instance's cache and returns the existing resampled instance in_resample_optionsas a tuple attribute on returned resampled trajectory instances for inspection.Validation
test_resample_caching_and_optionsintests/test_trajectory_analysis.pycovering cache hits, distinct option recalculations, and chaining from already-resampled instances.ruff check .passed with 0 lint errors.git diff --checkpassed cleanly.Closes #66