Skip to content

Get rid of magic assignment of implementation and element class #95

Description

@sixpearls

The only "gotcha" I can thiink of is for implementation, need to ensure user can change the implementation class. Currently an __implementation__ attribute on the Options should allow per-model specification which is likely sufficient for now. In general, explicitly set implementation as a ModelType attribute. Since this is a mutable attribute, it should also allow project-level specification of default. Then should rename the implementation classes to include Implementation to reduce confusion.

For fields, element_class should get set as a metaclass argument.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions