Enforce consistent file extensions

.github/workflows/static-analysis.yml

@@ -66,6 +66,40 @@ jobs:
             exit 1
           fi
 
+      # CML file extensions are .hh for header files and .cc for source files.
+      - name: File extensions are correct
+        run: |
+          wrong_extensions=(
+            c
+            h
+            cpp cxx cp "c++"
+            hpp hxx hp "h++"
+            tpp txx thh th
+          )
+          declare -A forbidden
+          for ext in "${wrong_extensions[@]}"; do
+            forbidden["$ext"]=1
+          done
+
+          violating_files=()
+          while IFS= read -r basename; do
+            [[ "$basename" != *.* ]] && continue
+            ext="${basename##*.}"
+            ext="${ext,,}"
+            if [[ -n "${forbidden[$ext]:-}" ]]; then
+              violating_files+=("$basename")
+            fi
+          done < <(git ls-files | awk -F/ '{print $NF}')
+
+          violations=${#violating_files[@]}
+          if [[ $violations -gt 0 ]]; then
+            echo "Incorrect extension found for $violations file(s)."
+            printf '\t%s\n' "${violating_files[@]}" | tee file-extension-issues.log
+            echo
+            echo "Headers must use .hh and source files must use .cc"
+          fi
+          exit "$violations"
+
       - name: Upload logs on failure
         if: failure()
         uses: actions/upload-artifact@v4
@@ -231,4 +265,4 @@ jobs:
           name: clang-tidy-failure-logs
           path: clang-tidy.log
           if-no-files-found: warn
-          retention-days: 2
+          retention-days: 2

models/dynamics/CMakeLists.txt

@@ -106,5 +106,5 @@ add_cml_tests(
         dynamics
 
     SOURCES
-        mass_derivative_dynamics/tests/test_mass_derivative_dynamics.cpp
+        mass_derivative_dynamics/test/test_mass_derivative_dynamics.cc
 )

models/environment/CMakeLists.txt

@@ -16,7 +16,7 @@ add_cml_library(
         atmos/atmosphere_models/DRWP_atmos/include/lookup_winds.hh
         atmos/atmosphere_models/simple_lookup_wind/include/simple_lookup_wind.hh
         atmos/atmosphere_models/std_atmos_1976/include/std_atmos_1976.hh
-        atmos/atmosphere_models/std_atmos_1976/src/std_atmos_formula.h
+        atmos/atmosphere_models/std_atmos_1976/src/std_atmos_formula.hh
         atmos/first_order_hold/include/first_order_hold.hh
         atmos/gust/include/gust.hh
         atmos/lagged_atmosphere/include/lagged_atmos_payload_data.hh

models/environment/atmos/atmosphere_models/DRWP_atmos/verif/SIM_lookup/Binaries/corrupt_binaries/README

@@ -1,2 +1,2 @@
-The source code WriteBinFile.cpp will generate the *.bin files if they ever
+The source code write_bin_file.cc will generate the *.bin files if they ever
 need to be modified.

models/environment/atmos/atmosphere_models/DRWP_atmos/verif/SIM_lookup/BinaryFileUtilities/.gitignore

@@ -0,0 +1,3 @@
+ReadBinFile
+ReadEntireBinFile
+WriteBinFile

models/environment/atmos/atmosphere_models/DRWP_atmos/verif/SIM_lookup/BinaryFileUtilities/makefile

@@ -1,13 +1,13 @@
 all : ReadBinFile WriteBinFile ReadEntireBinFile
 
-ReadBinFile : ReadBinFile.cpp
-		g++ -g -std=c++17 -Wall -Wextra -Werror -o ReadBinFile ReadBinFile.cpp -I.
+ReadBinFile : read_bin_file.cc
+		g++ -g -std=c++17 -Wall -Wextra -Werror -o ReadBinFile read_bin_file.cc -I.
 
-ReadEntireBinFile : ReadEntireBinFile.cpp
-		g++ -g -std=c++17 -Wall -Wextra -Werror -o ReadEntireBinFile ReadEntireBinFile.cpp -I.
+ReadEntireBinFile : read_entire_bin_file.cc
+		g++ -g -std=c++17 -Wall -Wextra -Werror -o ReadEntireBinFile read_entire_bin_file.cc -I.
 
-WriteBinFile : WriteBinFile.cpp
-		g++ -g -std=c++17 -Wall -Wextra -Werror -o WriteBinFile WriteBinFile.cpp -I.
+WriteBinFile : write_bin_file.cc
+		g++ -g -std=c++17 -Wall -Wextra -Werror -o WriteBinFile write_bin_file.cc -I.
 
 zap :
 		rm ReadBinFile ReadEntireBinFile WriteBinFile *.o

models/environment/atmos/atmosphere_models/DRWP_atmos/verif/SIM_lookup/BinaryFileUtilities/WriteBinFile.cpp → models/environment/atmos/atmosphere_models/DRWP_atmos/verif/SIM_lookup/BinaryFileUtilities/write_bin_file.cc

@@ -9,7 +9,6 @@ int main() {
   std::cout.precision(std::numeric_limits<double>::digits10);
 
   filename = "DRWP_6dependentvariables.bin";
-  int num_variables = 6;
   int nProfiles = 3;
   int nAltitudes = 5;
 

models/environment/atmos/atmosphere_models/std_atmos_1976/src/std_atmos_1976.cc

@@ -41,7 +41,7 @@ ASSUMPTIONS AND LIMITATIONS:
 #include "cml/models/utilities/cml_message/include/cml_message.hh"
 
 #include "../include/std_atmos_1976.hh"
-#include "std_atmos_formula.h"
+#include "std_atmos_formula.hh"
 
 
 STD1976::STD1976()

models/environment/atmos/atmosphere_models/std_atmos_1976/src/std_atmos_1976_dd.cc

@@ -28,7 +28,7 @@ LIBRARY DEPENDENCIES:
 #include "cml/models/utilities/cml_message/include/cml_message.hh"
 
 #include "../include/std_atmos_1976.hh"
-#include "std_atmos_formula.h"
+#include "std_atmos_formula.hh"
 
 
 const double STD1976::min_valid_alt = -5000.0;

models/environment/atmos/atmosphere_models/std_atmos_1976/src/std_atmos_formula.h → models/environment/atmos/atmosphere_models/std_atmos_1976/src/std_atmos_formula.hh

@@ -12,8 +12,8 @@
 
 ********************************************************************************/
 
-#ifndef CML_STD_ATMOS_FORMULA_H
-#define CML_STD_ATMOS_FORMULA_H
+#ifndef CML_STD_ATMOS_FORMULA_HH
+#define CML_STD_ATMOS_FORMULA_HH
 
 #include <cassert>
 #include <cmath>

models/tools/CMakeLists.txt

@@ -16,5 +16,5 @@ add_cml_tests(
         tools
 
     SOURCES
-        unit_test/models/tests/test_unit_framework.cc
+        unit_test/models/test/test_unit_framework.cc
 )

models/utilities/CMakeLists.txt

@@ -22,7 +22,7 @@ add_cml_library(
         constraint_check/include/valset_constraint.hh
         convert_string/include/convert_string.hh
         double_to_words/include/convert_double_to_words.hh
-        env_utils/include/env_utils.h
+        env_utils/include/env_utils.hh
         fault_arch/include/sSensorFaults.hh
         fault_management/include/fault.hh
         fault_management/include/fault_bias.hh

models/utilities/env_utils/include/env_utils.h → models/utilities/env_utils/include/env_utils.hh

@@ -1,5 +1,5 @@
-#ifndef CML_ENV_UTILS_H
-#define CML_ENV_UTILS_H
+#ifndef CML_ENV_UTILS_HH
+#define CML_ENV_UTILS_HH
 
 #include <cstdlib>
 #include <iostream>

models/utilities/env_utils/verif/SIM_verif/S_define

@@ -8,7 +8,7 @@ Purpose:(The sim)
 #define bad_env_variable "fhglkjdehglk"
 
 // Include headers for classes that this class contains:
-##include "cml/models/utilities/env_utils/include/env_utils.h"
+##include "cml/models/utilities/env_utils/include/env_utils.hh"
 ##include <stdexcept>
 ##include <string>
 

models/vehicle_management/compound_events/verif/SIM_verif_JIT/RUN_1_JIT/input.py

@@ -6,7 +6,7 @@
 when using JIT input files.
 
 Consequently, we have implemented the test run as a JIT-input files in
-input.cpp ***AS A DEVELOPMENT TEMPLATE ONLY *** to provide
+input.cc ***AS A DEVELOPMENT TEMPLATE ONLY *** to provide
 a guide as to how to implement the features of this model in an integrated
 simulation. However, the automated test runs ***DOES NOT USE*** this JIT-compiled
 implementations because we need to get code-coverage metrics from the
@@ -27,7 +27,7 @@
 verif.framework.data_file_name = "Unit_test_data/data.txt"
 
 
-'Here is the call that replaces input.cpp'
+'Here is the call that replaces input.cc'
 verif.jit_input_replacement()
 
 verif.manager.enabled = True

trickified/S_source.hh

@@ -63,7 +63,7 @@ PROGRAMMERS:
 #include "cml/models/environment/atmos/atmosphere_models/DRWP_atmos/include/lookup_winds.hh"
 #include "cml/models/environment/atmos/atmosphere_models/simple_lookup_wind/include/simple_lookup_wind.hh"
 #include "cml/models/environment/atmos/atmosphere_models/std_atmos_1976/include/std_atmos_1976.hh"
-#include "cml/models/environment/atmos/atmosphere_models/std_atmos_1976/src/std_atmos_formula.h"
+#include "cml/models/environment/atmos/atmosphere_models/std_atmos_1976/src/std_atmos_formula.hh"
 #include "cml/models/environment/atmos/first_order_hold/include/first_order_hold.hh"
 #include "cml/models/environment/atmos/gust/include/gust.hh"
 #include "cml/models/environment/atmos/lagged_atmosphere/include/lagged_atmos_payload_data.hh"
@@ -130,7 +130,7 @@ PROGRAMMERS:
 #include "cml/models/utilities/constraint_check/include/valset_constraint.hh"
 #include "cml/models/utilities/convert_string/include/convert_string.hh"
 #include "cml/models/utilities/double_to_words/include/convert_double_to_words.hh"
-#include "cml/models/utilities/env_utils/include/env_utils.h"
+#include "cml/models/utilities/env_utils/include/env_utils.hh"
 #include "cml/models/utilities/fault_arch/include/sSensorFaults.hh"
 #include "cml/models/utilities/fault_management/include/fault_bias.hh"
 #include "cml/models/utilities/fault_management/include/fault_function.hh"