Conversation
added 2 commits
June 24, 2026 14:43
Added function to cml_unit_sim.mk so that the -Wno-nonnull-compare only gets added to TRICK_C/XXFLAGS in a Linux environment as the compile flag is not compatible with Clang Fixed overloading and fpe compile errors for SIM_Test_table. Using SIM_Test_table as the test case to get Mac working with CML. Currently seeing SWIG error where SWIG is attempting to access private things within a class. Refs #16
…D=1 on Mac Also includes #ifdef SWIG fix for swig attempting to access private class information Refs #16
ninotarantino
self-requested a review
July 23, 2026 15:04
Contributor
|
This is a few commits behind so go ahead and rebase or merge main into this branch first. |
Branch works on Linux as well. Refs #16
ninotarantino
requested changes
Aug 14, 2026
| TRICK_LDFLAGS += -L${CML_LIBRARY_DIR} | ||
| ifeq (1, $(CML_USE_STATIC_LIB)) | ||
| TRICK_LDFLAGS += -l:libcml.a | ||
| else ifeq ($(findstring Darwin,$(trick-gte TRICK_HOST_CPU)),) |
Contributor
There was a problem hiding this comment.
Could probably just make this a direct comparison with Darwin using trick-gte TRICK_HOST_TYPE instead.
Contributor
Author
There was a problem hiding this comment.
Need to keep it as it is because trick-gte TRICK_HOST_CPU returns Darwin_25 on my Mac. I don't know if Darwin_* will change for different Mac versions in the future. Or we can specify Darwin_25 for now.
Comment on lines
+34
to
+36
| #ifdef SWIG | ||
| %immutable; | ||
| #endif |
Contributor
There was a problem hiding this comment.
I added these in the Rocky 9 compatibility branch which was just merged. Go ahead and revert the ones on this branch and see if the ones I added are enough to get builds on mac working.
Comment on lines
-12
to
-14
| ifeq ($(shell pkg-config --exists libxml-2.0 && echo $$?),0) | ||
| export TRICKIFY_CXX_FLAGS += $(shell pkg-config libxml-2.0 --cflags) | ||
| endif |
Contributor
There was a problem hiding this comment.
This is probably going to cause the Rocky build to fail because it won't be able to find libxml types that the headers need.
added 3 commits
August 26, 2026 17:23
- removed lines that got unit sims compile with the overloaded-virtual compiler flag error - a quick check to only use GCC specific compiler warnings if a user is compiling with GCC - removing a check to see if Trick exists from the test script Other issues to potentially be fixed with a merge with main Refs #16
jman025
marked this pull request as ready for review
August 28, 2026 18:13
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.