Repository navigation
Add null pointer check and comment cleanup - #123
Open
Minsoo-Kang-space wants to merge 5 commits into
Open
Minsoo-Kang-space wants to merge 5 commits into
Minsoo-Kang-space wants to merge 5 commits into
Conversation
ninotarantino
requested changes
Sep 30, 2026
ninotarantino
left a comment
ninotarantino
left a comment
Contributor
There was a problem hiding this comment.
Mostly looks good, there's just the two small changes. There's a few merge conflicts in here as well, which are why the CI is failing. Deleted copy constructor and copy assignment operator are already present in the public sections of the classes you added them to, which is where they should be placed.
Minsoo-Kang-space
changed the title
Minsoo-Kang-space
force-pushed
the
vehicle_management-compound_events
branch
from
October 1, 2026 21:18
7cc1821 to
ec3c460
Compare
Minsoo-Kang-space
marked this pull request as ready for review
October 1, 2026 21:18
Minsoo-Kang-space
force-pushed
the
vehicle_management-compound_events
branch
3 times, most recently
from
October 2, 2026 20:51
53aa2f1 to
2905d41
Compare
…auto for dynamic_cast, mark has_managed_value as const
Minsoo-Kang-space
force-pushed
the
vehicle_management-compound_events
branch
from
October 6, 2026 16:36
2905d41 to
8501a00
Compare
Collaborator
|
coverage: 88.33% (+0.004%) from 88.326% — vehicle_management-compound_events into main |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaning up comments and the documentation
Adding null pointer check
Updating enhanced logging configuration for Artemis3