Add updated events manager model from ramtares_main - #120
Open
Minsoo-Kang-space wants to merge 1 commit into
Open
Minsoo-Kang-space wants to merge 1 commit into
Minsoo-Kang-space wants to merge 1 commit into
Conversation
Minsoo-Kang-space
marked this pull request as ready for review
September 24, 2026 16:01
ninotarantino
requested changes
Sep 24, 2026
Comment on lines
+50
to
+56
| // if (require_all) { | ||
| // // force multi_shot for all triggers when the set requires all triggers | ||
| // // to be fulfilled for the set to be fulfilled. This fixes a discrepancy | ||
| // // with DataCollect's behavior without requiring the logging user to be | ||
| // // careful with the multi_shot optimization. | ||
| // trigger->multi_shot = true; | ||
| // } |
Contributor
There was a problem hiding this comment.
Commented-out code isn't allowed unless there's some additional metadata included: https://nasa.github.io/cml/contributing/coding-standards.html#cml-mcs-general-5-commented-out-code-shall-only-be-allowed-when-accompanied-by-an-associated-project-issue-point-of-contact-email-address-and-current-date.
Why is this commented out? What additional changes are necessary before uncommenting it? If this comment remains in, it needs to be specific about what "DataCollect" refers to. No such type or function exists in CML, Trick, or JEOD.
Comment on lines
+416
to
+418
| // Semantically equivalent to static_cast<bool>(ref) (i.e., ref != 0.0), | ||
| // but avoids '=='/'!=' comparisons that trigger -Wfloat-equal. | ||
| reference = (ref > 0.0) || (ref < 0.0) || std::isnan(ref); |
Contributor
There was a problem hiding this comment.
Use the standard library.
Suggested change
| // Semantically equivalent to static_cast<bool>(ref) (i.e., ref != 0.0), | |
| // but avoids '=='/'!=' comparisons that trigger -Wfloat-equal. | |
| reference = (ref > 0.0) || (ref < 0.0) || std::isnan(ref); | |
| reference = std::fpclassify(ref) != FP_ZERO; |
| tested more than once per cycle, leading to unintended behavior.*/ | ||
| Boolean used to lock at each cycle, so each WatchValuesBase cannot be | ||
| tested more than once per cycle. Elaborate extension of WatchValuesBaseCore | ||
| -- such as EventTrigger -- caan create false negatives if evaluated |
Contributor
There was a problem hiding this comment.
Spelling.
Suggested change
| -- such as EventTrigger -- caan create false negatives if evaluated | |
| -- such as EventTrigger -- can create false negatives if evaluated |
Comment on lines
+74
to
+75
| (commonly set when an WatchValue is added to the CompoundEventsManager's | ||
| managed_triggers listi, such as when using create)trigger(...)) |
Contributor
There was a problem hiding this comment.
Grammar.
Suggested change
| (commonly set when an WatchValue is added to the CompoundEventsManager's | |
| managed_triggers listi, such as when using create)trigger(...)) | |
| (commonly set when a WatchValue is added to the CompoundEventsManager's | |
| managed_triggers list, such as when using create_trigger(...)) |
Collaborator
|
coverage: 89.461% (+0.005%) from 89.456% — vehicle_management-events_manager into main |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Safe state of CML for support of GNC_PAR upgrade]
[Enhanced Logging Model Content]