Add missing lookup_winds functionsAdd missing lookup_winds functions from ramtares_main - #119
Draft
Minsoo-Kang-space wants to merge 1 commit into
Draft
Minsoo-Kang-space wants to merge 1 commit into
Minsoo-Kang-space wants to merge 1 commit into
Conversation
ninotarantino
requested changes
Sep 24, 2026
Comment on lines
+222
to
+225
| void compute_average_wind_interp( size_t table_index, | ||
| double min_altitude=0, | ||
| double max_altitude=0, | ||
| double altitude_incr=0); |
Contributor
There was a problem hiding this comment.
The default arguments for this don't make sense. An altitude increment of zero would never be useful and it's the last argument, so we always need to specify values for every argument. It would also result in a divide-by-zero in the function itself since there's no protection against that case.
|
|
||
| /****************************************************************************/ | ||
| void | ||
| LookupAtmosWinds::compute_average_wind_interp( |
Contributor
There was a problem hiding this comment.
This is major new functionality that needs to be tested and documented before being merged.
| // Leave average at zero-vector | ||
| return; | ||
| } | ||
| size_t num_alts = (max_alt_ - min_alt_) / step_alt + 1; |
Contributor
There was a problem hiding this comment.
Needs divide-by-zero protection.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Add missing lookup_winds functions]