The DRWP Atmos model's SIM_lookup has a BinaryFileUtilities directory that builds several utilities. These are not well documented, don't build as-committed, and aren't tested in CI. The tool that can be built in the Binaries directory has similar issues, although it has no makefile at all. All of these issues need to be addressed, or the files need to be removed if they're no longer needed (which the README suggests but does not take a definitive stance on).
If these files are necessary (likely, they're mentioned in the verification section of the model documentation), they need to be held to the same standard as the rest of CML. They'll need to be built with the same warning flags as the rest of CML and pass all static analysis checks.
The DRWP Atmos model's
SIM_lookuphas aBinaryFileUtilitiesdirectory that builds several utilities. These are not well documented, don't build as-committed, and aren't tested in CI. The tool that can be built in theBinariesdirectory has similar issues, although it has no makefile at all. All of these issues need to be addressed, or the files need to be removed if they're no longer needed (which the README suggests but does not take a definitive stance on).If these files are necessary (likely, they're mentioned in the verification section of the model documentation), they need to be held to the same standard as the rest of CML. They'll need to be built with the same warning flags as the rest of CML and pass all static analysis checks.