Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Keep an indirect mesh conversion when its eight input bytes are disjoint from every known storage write made by the preceding mesh draw. Overlapping records are discarded. Unknown writes, unsized buffers and sparse ranges retain the existing invalidation path. Also record the Metal indirect mesh selector on the optional encoding thread.
This is a stacked draft based on seedds#1312. The base provides the indirect mesh path.
Measurements
Ocarina of Time 1.1.1, M3 Max, docked, game NDSR, fixed view at the top of Link's ladder in Kokiri Forest. Both versions used the same wide-write optimization and game resources. The direct-encoding A/B produced 24.8 → 27.4 FPS, then 24.4 → 26.4 FPS in the reverse order. In four profiled images, indirect conversion splits dropped from 24 to 8, and the main colour/depth passes averaged 28.4 → 25.3 ms of GPU work. Frame captures and the local test covered this route. The reported foliage animation issue remains open.
Checks
t_mesh_indirectpassed with Metal validation in both encoding modes. It tests GPU-produced arguments, overlap with the second source word, preservation of a disjoint record, and the unknown-size fallback.