Open
Conversation
AaronDJohnson
requested changes
Sep 19, 2024
Collaborator
AaronDJohnson
left a comment
There was a problem hiding this comment.
It's a good start to something that will be very useful. I recommend moving to the ArrayLikelihood which uses vmap across pulsars with the same noise models to be much faster on a GPU for these models which meet the requirements to use it. I've recommended code which should work. There are a couple of design options that we could pick:
- psr.noisedict vs noisedict
- common_type string vs correlation function
AaronDJohnson
approved these changes
Jan 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a start. There's much that could be done here.
Example usage:
model_curn_vg = models.lhood_maker(psrs, wn_params, gamma_common=None, common_components=14, red_components=30, common_type='curn')