Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new "Clock" coding challenge (difficulty 2) across all 6 supported languages (C, Dart, JavaScript, Kotlin, Python, Swift) and all 12 locales (en, de, es, fr, hi, it, ja, ko, pl, pt, ru, zh). The exercise asks the user to implement a
clockTimefunction that formats hours/minutes into a clock display string.challenges/clock.mdfiles (6 languages x 12 locales)challenges/data.jsonentries with difficulty 2 and a translated name (Clock/Uhr/Reloj/Horloge/घड़ी/Orologio/時計/시계/Zegar/Relógio/Часы/时钟)assets/challenges/clock.svgChecks run
entype-1 challenge files PASS — c 3s, dart 4s, javascript 2s, kotlin 3s, python 1s, swift 3s (each "Ran 1 exercises: 1 passed, 0 failed, 0 skipped"). Also re-ran all 6jafiles after translation fixes — all PASS.scripts/check_locales.py— 0 problems across 12 en files x 11 locales;scripts/check_string_literals.py— 0 unterminated string literals.Fixes applied during review
clockentry (difficulty: 2, name時計) to 5 Japanesedata.jsonfiles that had none (ja/c, ja/dart, ja/javascript, ja/kotlin, ja/swift — only ja/python had been updated), appended surgically preserving existing formatting.ja/kotlin/challenges/clock.mdandja/swift/challenges/clock.md, which had been left entirely in English (caught by the title-vs-data.json-name sync validation rule). Spliced in the Japanese prose fromja/dart/challenges/clock.mdsince the English description/instructions are byte-identical across all 6 languages.Known issues
curriculum.jsonand_theory.mdfiles are unchanged and absent from this diff. This is expected/informational, not a defect:curriculum.jsononly indexes arguments, never challenges (confirmed no "anagram" or "clock" strings appear in it), and there is no_theory.mdin anychallenges/folder for any language.Test plan