Restore the remaining missing diacritics in the Portuguese locale - #327
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #326, which only caught part of this.
That PR's detector looked for description prose of 120+ characters containing no diacritic at all. It therefore missed every section that had some accents alongside a few misspelled words, and it never looked at
--instructions--,--answers--or--solutions--.A word-level detector finds the rest — 811 sections in 540 files:
codigovariavelsaidanaocondicaoinstrucaoRepo-wide the accented spellings dominate — "código" 1459 to "codigo" 540, "função" 2037 to "funcao" 26 — so the unaccented text is a straggler, not a house style.
What changed
The missing accents, and nothing else. No rewording, no reordering, no punctuation.
The judgement calls are the ones that change meaning rather than spelling:
e(and) vsé(is),avsà(crase),estavsestá,temvstêm. Each was resolved by reading the clause — several lines contain both readings in sequence, e.g. "timeé menor que12, e no bloco de código imprima".Diff shape
_theory.mdfiles, +49 / −49.curriculum.jsonunchanged.Checks
ç→c) reproduces the old text character-for-character. That is what proves only accents moved and no prose was quietly rewritten.exerciseType: 3file still has its--solutions--bullet character-identical to one of its--answers--bullets — the validator matches those as exact strings.--output--,--asserts--,--seed--and the other executed sections: byte-identical. This mattered:it's equivalent defect hides insideprint("E' ora del caffe'!"), which is byte-compared against--output--, so accenting blindly would have broken exercises.pt/python/dictionaries/2.md, where the change is a Portuguese prose comment (# obtem→# obtém). The code itself is untouched."Codigo"is a string literal,indices/lastIndexare Kotlin API names, andespecificathere is the verb (no accent), not the adjective.+275436: All tests passed!