Extract a pure chart package - #18
Merged
Merged
Conversation
pixelRows and renderBraille recomputed lo/hi from the downsampled array instead of using the true series bounds the axis labels are drawn from. When cols*2 < len(series), a narrow peak can be smoothed below the true max by interpolation before sampling, so the line would report as touching the axis top even though the labeled max is much higher. Both now take lo, hi as parameters, and Render passes through the raw-series bounds it already computed for the axis. Also removes the unused braille2 test helper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
No intended visual change except the downsampled-series scaling fix.