Merged
Conversation
Python typemaps and template instantiations are now in libcdoc.i (#ifdef SWIGPYTHON), eliminating the need for the build-time patch. - Point submodule to namespace-ee/libcdoc (feature/python-swig-bindings) - Remove patch mechanism from CMakeLists.txt - Remove patches/libcdoc-python.patch Upstream PR: open-eid/libcdoc#101
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feature/python-swig-bindingsbranch) which includes Python typemaps directly inlibcdoc.ivia#ifdef SWIGPYTHONpatches/libcdoc-python.patch+ CMakeexecute_process)Context
Upstream PR: open-eid/libcdoc#101
Once the upstream PR is merged, the submodule can be pointed back to
open-eid/libcdoc.Test plan
uv pip install -e . --no-build-isolationbuilds successfully