Change DialogFragment#413
Open
s-cortes wants to merge 1 commit intonaman14:masterfrom
s-cortes:patch-3
Open
Conversation
When there was multiple rotations, the application generate an IllegalStateException. Be cause of that, it is necessary to change some of the code of this class to avoid the problem. for example, using the method getParentFragment. Also, adding saved instances.
|
hi
…On Mon, Nov 19, 2018 at 10:05 AM Santiago Cortés Fernández < ***@***.***> wrote:
When there was multiple rotations, the application generate an
IllegalStateException. Be cause of that, it is necessary to change some of
the code of this class to avoid the problem. for example, using the method
getParentFragment. Also, adding saved instances.
------------------------------
You can view, comment on, or merge this pull request online at:
#413
Commit Summary
- Change DialogFragment
File Changes
- *M*
app/src/main/java/com/naman14/timber/dialogs/LastFmLoginDialog.java
<https://github.com/naman14/Timber/pull/413/files#diff-0> (35)
Patch Links:
- https://github.com/naman14/Timber/pull/413.patch
- https://github.com/naman14/Timber/pull/413.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#413>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AWRoxrLD_JqLgD2vBqI-2MyQVbCvXilsks5uwjwvgaJpZM4YoaWe>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there was multiple rotations, the application generate an IllegalStateException. Because of that, it is necessary to change some of the code of this class to avoid the problem. for example, using the method getParentFragment. Also, adding saved instances.