Skip to content

Add reading mode test and fix Update workflow #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nahcnuj merged 7 commits into from
Aug 22, 2026
Merged

Add reading mode test and fix Update workflow #802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
28304e3
Update CI to use reading-mode test script and rename script
nahcnuj Aug 22, 2026
7dbee7b
Run readability helper script directly in CI VRT job
nahcnuj Aug 22, 2026
e3f4a8d
Restore VRT test scripts and CI workflow from main
nahcnuj Aug 22, 2026
29185f9
Update workflow and remove test.pdf
nahcnuj Aug 22, 2026
2eb0ed0
Update update.yml to use test:reading script
nahcnuj Aug 22, 2026
74c8ef2
Remove test.pdf
nahcnuj Aug 22, 2026
1cd2c13
Fix Update workflow: install Playwright and ensure test:reading works
nahcnuj Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/update.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,13 @@ jobs:
node-version-file: '.nvmrc'
cache: 'npm'
- name: Install dependencies
run: npm ci --omit dev --ignore-scripts --prefer-offline
run: npm ci --ignore-scripts --prefer-offline
- name: Install Playwright browsers
run: npx playwright install chromium
- name: Build site
run: npm run build
- name: Install Playwright browsers
run: npx playwright install chromium
- name: Run readability test on built site
run: npm run test:reading
- if: failure()
Expand Down
Binary file removed app/fixtures/essays/test.pdf
View file
Open in desktop
Binary file not shown.
Loading