Skip to content

CI: bump JDK to temurin@17 - #505

Open
nafg wants to merge 2 commits into
masterfrom
fix/ci-jdk17
Open

CI: bump JDK to temurin@17#505
nafg wants to merge 2 commits into
masterfrom
fix/ci-jdk17

Conversation

@nafg

@nafg nafg commented Aug 20, 2026

Copy link
Copy Markdown
Owner

The generated workflow was pinned to temurin@11. sbt 2.x requires JDK 17+, so scala-steward's "Update sbt to 2.0.x" PR cannot pass CI on JDK 11.

This sets githubWorkflowJavaVersions := Seq(JavaSpec.temurin("17")) in ci.sbt and regenerates .github/workflows/ci.yml (and .mergify.yml, via sbt-mergify-github-actions, whose check-success names embed the java version). project/build.properties is untouched — the sbt bump stays scala-steward's PR.

Verified locally on temurin 17: githubWorkflowCheck passes, and +test (against the docker-compose mysql/postgres, testkit-github.conf) passes on 2.12.21, 2.13.18, and 3.3.8 — 79 tests each.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 290c449f-261d-44e7-a394-24302509a4c8

📥 Commits

Reviewing files that changed from the base of the PR and between 703dc2c and 6bea177.

⛔ Files ignored due to path filters (1)
  • .github/workflows/ci.yml is excluded by !**/*.yml
📒 Files selected for processing (1)
  • .scala-steward.conf

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The change pins two Scala 3 library artifacts to the 3.3. version line and changes the GitHub Actions Java runtime from Temurin 11 to Temurin 17.

Changes

Scala dependency pin

Layer / File(s) Summary
Scala Steward LTS pins
.scala-steward.conf
Scala Steward pins scala3-library_3 and scala3-library_sjs1_3 to the 3.3. version prefix.

CI Java runtime

Layer / File(s) Summary
Temurin Java 17 configuration
ci.sbt
The configured GitHub Actions Java version changes from Temurin 11 to Temurin 17.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 6bea1

The PR updates CI to JDK 17 and pins the Scala 3 build line, with the stated checks and cross-version tests passing; no actionable merge-blocking risk remains beyond normal review.

Possibly related PRs

Poem

A rabbit pins Scala three,
And sets Java seventeen free.
CI hops through the queue,
With configs fresh and true,
While carrots compile happily.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the primary CI change: updating the JDK to Temurin 17.
Description check ✅ Passed The description accurately explains the CI JDK update, Scala Steward context, regenerated workflows, and verification results.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ci-jdk17

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mergify

mergify Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@nafg nafg changed the title CI: bump JDK to temurin@17; pin Scala 3 to LTS CI: bump JDK to temurin@17 Aug 20, 2026
nafg and others added 2 commits August 20, 2026 04:41
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant