CI: bump JDK to temurin@17 - #505
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change pins two Scala 3 library artifacts to the ChangesScala dependency pin
CI Java runtime
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to The PR updates CI to JDK 17 and pins the Scala 3 build line, with the stated checks and cross-version tests passing; no actionable merge-blocking risk remains beyond normal review. Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Tick the box to add this pull request to the merge queue (same as
|
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The generated workflow was pinned to
temurin@11. sbt 2.x requires JDK 17+, so scala-steward's "Update sbt to 2.0.x" PR cannot pass CI on JDK 11.This sets
githubWorkflowJavaVersions := Seq(JavaSpec.temurin("17"))inci.sbtand regenerates.github/workflows/ci.yml(and.mergify.yml, via sbt-mergify-github-actions, whosecheck-successnames embed the java version).project/build.propertiesis untouched — the sbt bump stays scala-steward's PR.Verified locally on temurin 17:
githubWorkflowCheckpasses, and+test(against the docker-compose mysql/postgres,testkit-github.conf) passes on 2.12.21, 2.13.18, and 3.3.8 — 79 tests each.🤖 Generated with Claude Code