Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion project/build.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.12.14
sbt.version=2.0.4

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟑 Minor | ⚑ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -eu

# Check build definitions and plugins for upgrade-sensitive code.
rg -n '(^|[[:space:]])[A-Za-z0-9_]+:[A-Za-z0-9_]+' build.sbt project --glob '*.sbt' --glob '*.scala' || true
rg -n 'addSbtPlugin|sbtPlugin|scalaVersion|exportJars|Def\.uncached' build.sbt project --glob '*.sbt' --glob '*.scala' || true

# Check CI/toolchain declarations for JDK versions.
rg -n 'java-version|JAVA_HOME|jdk|temurin|zulu|java:' .github .circleci Dockerfile* Jenkinsfile* 2>/dev/null || true

Repository: nafg/slick-migration-api

Length of output: 1177


🏁 Script executed:

#!/bin/bash
set -eu

printf '--- files ---\n'
git ls-files 'project/*' 'build.sbt' '.github/workflows/*.yml' Dockerfile* 2>/dev/null || true

printf '\n--- project/build.properties ---\n'
cat -n project/build.properties

printf '\n--- build.sbt header ---\n'
sed -n '1,120p' build.sbt | cat -n

printf '\n--- project plugins ---\n'
cat -n project/plugins.sbt

printf '\n--- workflow relevant sections ---\n'
sed -n '1,140p' .github/workflows/ci.yml | cat -n

printf '\n--- publish-related settings ---\n'
rg -n 'publish|publishArtifact|sonatype|coursierResolver|dependencyResolution|organization|Test|Compile|Defaults|Settings|Compile / package|coverageEnabled|coverageEnabled|coverageExcludedPackages|coveralls' build.sbt project --glob '*.sbt' --glob '*.scala' || true

printf '\n--- scala/sbt/version references ---\n'
rg -n 'scalaVersion|crossScalaVersions|scalaRelease|sbt.version|scalaVersion :=' build.sbt project .github --glob '*.yml' --glob '*.yaml' --glob '*.scala' --glob '*.sbt' || true

Repository: nafg/slick-migration-api

Length of output: 253


🏁 Script executed:

#!/bin/bash
set -eu

echo '--- files ---'
git ls-files 'project/*' 'build.sbt' '.github/workflows/*.yml' Dockerfile* 2>/dev/null || true

echo
echo '--- project/build.properties ---'
cat -n project/build.properties

echo
echo '--- build.sbt header ---'
sed -n '1,120p' build.sbt | cat -n

echo
echo '--- project plugins ---'
cat -n project/plugins.sbt

echo
echo '--- workflow relevant sections ---'
sed -n '1,140p' .github/workflows/ci.yml | cat -n

echo
echo '--- publish-related settings ---'
rg -n 'publish|publishArtifact|sonatype|coursierResolver|dependencyResolution|organization|Test|Compile|Defaults|Settings|Compile / package|coverageEnabled|coveralls' build.sbt project --glob '*.sbt' --glob '*.scala' || true

echo
echo '--- scala/sbt/version references ---'
rg -n 'scalaVersion|crossScalaVersions|scalaRelease|sbt.version|scalaVersion :=' build.sbt project .github --glob '*.yml' --glob '*.yaml' --glob '*.scala' --glob '*.sbt' || true

Repository: nafg/slick-migration-api

Length of output: 7375


🌐 Web query:

SBT 2.0 JDK 17 requirement documentation

πŸ’‘ Result:

sbt 2.x requires a minimum of JDK 17 to run [1][2][3]. This requirement is strictly enforced; the sbt runner is designed to detect the JDK version before launching and will terminate with an error message if it detects a version lower than JDK 17 [4]. The decision to move to JDK 17 as the baseline is driven by the fact that sbt 2.x uses Scala 3.8.x for build definitions and plugins [2][3], which itself requires JDK 17 or higher [2][3]. Official documentation recommends using Eclipse Adoptium Temurin JDK 17 [1]. While sbt 2.x requires JDK 17 to execute the build process, you can still compile code targeting older JDK versions (such as JDK 8) by using the --release flag in your build configuration [5].

Citations:


Align the build with SBT 2.x before relying on this version bump.

project/build.properties now pins SBT 2.0.4, which requires JDK 17, but the CI builds and publish job still run with Temurin 11. Update .github/workflows/ci.yml to JDK 17 and review the SBT 2.x migration notes for plugin/build-definition compatibility before merging.

πŸ€– Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@project/build.properties` at line 1, Update the CI and publish job Java setup
in .github/workflows/ci.yml from Temurin 11 to JDK 17 to support the sbt.version
2.0.4 change, and verify the build definition and plugins follow SBT 2.x
migration requirements before merging.

Loading