Repository navigation
Adding Apple 2FA (SMS confirmation) for login - #32
Open
mindflowgo wants to merge 1 commit into
Open
mindflowgo wants to merge 1 commit into
mindflowgo wants to merge 1 commit into
Conversation
Pick the real trusted number id before requesting the SMS code, and when Apple answers 412 for a number id that is not on the account, parse the challenge's trusted numbers and let the user pick through the two-factor callback instead of aborting the login.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior code failed when Apple rejected login with 412 (SMS 2FA)...
This code just touches the 2 places to enable that capability. Tested logging in to account that logged in without 2FA trigger, and one that did have 2FA trigger. Both worked.