Repository navigation
Fix analytics role totals for region and area filters - #3
Merged
Merged
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analytics → Nodes used the API's global role-count metadata even when the node list was filtered by region or area. Role Breakdown now counts the same loaded nodes used for Network Status, so regional totals agree and empty selections show zero counts. Missing and unrecognized roles are grouped as unknown; badges use the shared role colours.
Addresses Kpa-clawbot#2213. This is a focused follow-up based on
codex/dev-analytics-readiness, preserving the already deployed asynchronous-rendering and Canadaverse changes.Local validation passed: all standalone frontend suites, server and ingestor Go suites, 42 analytics lifecycle tests, and eight browser scenarios against an isolated Go/SQLite instance. The regression failed before the fix and passes after it. Full CI also passed both database backends, all browser shards, race checks, and packaged images/startup checks for
73bffc8465760a1f55aeaa016b9d121dbd8d5224.The tally runs inside the existing O(n) status pass over the node list (capped at 10,000 by
fetchAllNodes). It keeps a fixed set of role buckets and adds no requests, dependencies, backend changes, or settings.Verified deployment
Commit
73bffc8465760a1f55aeaa016b9d121dbd8d5224is deployed to Canadaverse CoreScope. The public API reports that commit, and the browser-delivered JavaScript hashes match the committed files.Live checks verified YKF: 28 repeaters + 4 companions + 2 rooms = 34 nodes; YYZ: 60 repeaters + 3 companions + 4 rooms = 67 nodes. Those values are observations at validation time, not fixed network totals. Switching between the regions preserved matching totals with no browser JavaScript errors.
The application is healthy on PostgreSQL, the existing account is preserved, both Canadian MQTT sources are fresh, and write errors are zero. Configuration, theme, memory limits and retention settings were preserved; no other container changed. The previous image and private configuration snapshot remain available for rollback.