feat: Add dynamic multi-interface support for mDNS discovery#4025
Open
DarkmatterVale wants to merge 1 commit inton0-computer:mainfrom
Open
feat: Add dynamic multi-interface support for mDNS discovery#4025DarkmatterVale wants to merge 1 commit inton0-computer:mainfrom
DarkmatterVale wants to merge 1 commit inton0-computer:mainfrom
Conversation
rklaehn
reviewed
Mar 20, 2026
| .filter_map(|(_, iface)| { | ||
| iface | ||
| .addrs() | ||
| .find(|i| i.addr().is_ipv4()) |
Contributor
There was a problem hiding this comment.
Isn't this basically filter_map?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for dynamic multi-interface mDNS discovery in iroh. Specifically, previously, if interfaces dynamically changed after creating the endpoint, it would not discover the new endpoints and add them to mDNS. With this PR, interfaces that are added / removed are properly handled.
Breaking Changes
There are no breaking changes.
Notes & open questions
Change checklist
quic-rpciroh-gossipiroh-blobsdumbpipesendme