Open
Conversation
This allows us to disable captive portal checks and https probes on esp32
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/4020/docs/iroh/ Last updated: 2026-03-25T08:47:48Z |
To avoid the weird config in options thing in the wasm branch
flub
reviewed
Mar 19, 2026
| /// Controls which probes and checks are performed when generating network reports. | ||
| /// All options default to `true`. | ||
| #[derive(Debug, Clone)] | ||
| #[non_exhaustive] |
- rename :net_report::Config to Nnet_report::NetReportConfig - better documentation of net report config options
Contributor
|
(/me deferring to @dignifiedquire for the rest of this review) |
rklaehn
force-pushed
the
configure-probes
branch
from
a0429f2 to
21bb422
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This allows us to disable captive portal checks and https probes on esp32
Breaking Changes
None
Notes & open questions
Should we also allow for disabling QAD probes? I was thinking we leave it for later. The config object is non-exhaustive.
Change checklist
quic-rpciroh-gossipiroh-blobsdumbpipesendme