Skip to content

chore(public/sendme.sh): Make script a bit more robust and verbose#444

Merged
Arqu merged 4 commits inton0-computer:mainfrom
yermulnik:main
Mar 25, 2026
Merged

chore(public/sendme.sh): Make script a bit more robust and verbose#444
Arqu merged 4 commits inton0-computer:mainfrom
yermulnik:main

Conversation

@yermulnik
Copy link
Copy Markdown
Contributor

@yermulnik yermulnik commented Mar 25, 2026

Related to #318

  • Wrap cmdline params to prevent globbing and word splitting
  • Simplify how the release archive name is identified
  • Add verbosity to tar to allow user to see where the binary is unpacked to
  • Make tar and rm command safer
  • Add an output message on archive extraction to improve user experience
  • Make grep'ing more robust
  • Add error message if release not found

Related to #318

* Wrap cmdline params to prevent globbing and word splitting
* Add verbosity to `tar` to allow user to see where the binary is unpacked to
Copilot AI review requested due to automatic review settings March 25, 2026 10:01
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 25, 2026

@yermulnik is attempting to deploy a commit to the number 0 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates public/sendme.sh to make the download/extract flow safer and more transparent when fetching the latest release artifact.

Changes:

  • Quote $release_archive when passing it to curl, unzip, and rm to prevent globbing/word-splitting.
  • Enable verbose extraction output for the tar-based download path.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@n0bot n0bot bot added this to iroh Mar 25, 2026
@github-project-automation github-project-automation bot moved this to 🚑 Needs Triage in iroh Mar 25, 2026
@yermulnik yermulnik changed the title chore(public/sendme.sh): Wrap vars and add verbosity chore(public/sendme.sh): Make script a bit more robust and verbose Mar 25, 2026
@matheus23 matheus23 requested a review from Arqu March 25, 2026 11:16
@Arqu Arqu merged commit 6ec6860 into n0-computer:main Mar 25, 2026
2 of 3 checks passed
@github-project-automation github-project-automation bot moved this from 🚑 Needs Triage to ✅ Done in iroh Mar 25, 2026
@Arqu
Copy link
Copy Markdown
Contributor

Arqu commented Mar 25, 2026

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants