Fix: wallpaper-restore.sh (safe expansion, handle spaces, add robustness checks)

[rajghosh06-dev]

Description

This pull request fixes wallpaper-restore.sh by improving path handling, safe ~ expansion, support for spaces, and robust fallback mechanisms.

PATH: ~/.config/hypr/scripts/wallpaper-restore.sh

---

Changes

• Improved
• Bug Fixes
• Feature
• Documentation
• Other

Context

The previous script had reliability issues:

• Unsafe ~ expansion using sed
• Paths with spaces breaking due to unquoted variables
• Relative/malformed cache entries slipping through
• Broken symlinks not detected
• Non-image files accepted, causing restore errors
• Limited and inconsistent default wallpaper fallback

This PR ensures wallpapers are restored reliably across Arch + Hyprland + ML4W OS setups.

How Has This Been Tested?

• Tested on Arch Linux/Based Distro.
• Tested on Fedora Linux/Based Distro.
• Tested on openSuse.

Tested Scenarios (on local machine)

• ~/Pictures/... paths → expand correctly
• /home/user/Pictures/... absolute paths → remain untouched
• Paths containing spaces (e.g., Holiday Photos) → handled safely
• Empty or malformed cache entries → fall back to default wallpaper
• Broken symlinks → fall back to default wallpaper
• Non-image files (e.g., cached .txt) → rejected, default wallpaper used

Result: These tests confirm that corrupted paths are prevented and wallpapers are restored reliably across different setups.

Checklist

Please ensure your pull request meets the following requirements:

• My code follows the style guidelines of this project.
• I have performed a self-review of my code.
• I have commented on my code, particularly in hard-to-understand areas.
• My changes do not introduce new warnings.
• I have added tests that prove my fix is effective or that my feature works.
• I have made corresponding changes to the documentation
• New and existing unit tests pass locally with my changes.

Screenshots

N/A

Related Issues

Fixes reliability issues in wallpaper-restore.sh.

Other related Issues are mentioned in Comments.

Additional Notes

• Safe ~ expansion (only leading ~)
• Quoted variables for paths with spaces
• Path normalization with realpath -m
• Guards for empty/malformed cache entries
• Detection of broken symlinks
• Validation to reject non-image files
• Robust default wallpaper fallback in all failure cases

---

Note to Maintainers
Thank you for reviewing this contribution.
The changes are focused on improving reliability and robustness without altering existing functionality.
I appreciate your time and feedback, and I’m happy to make any adjustments if needed.

---

[rajghosh06-dev]

Related/Similar Issues:

• (already closed) Addresses concerns raised in [BUG] Allow spaces in Wallpaper file names #1047

• Relates to [BUG] wallpaper modes/blur not turning off #1426 (Wallpaper modes/blur not turning off)

• Relates to [FEATURE] Daily Wallpaper #1442 (Daily Wallpaper automation enhancement)

• Relates to Arch system package update broke waypaper and pywalfox #1394 (Waypaper/Pywalfox breaking wallpaper restore)

• Any other related to Wallpaper Automation Problem & Restore the last used Wallpaper before/after Restart or after a Full Shutdown.