Skip to content

chore: add enterprise dev workflow#1

Merged
markm39 merged 3 commits into
masterfrom
chore/dev-workflow
Mar 28, 2026
Merged

chore: add enterprise dev workflow#1
markm39 merged 3 commits into
masterfrom
chore/dev-workflow

Conversation

@markm39

@markm39 markm39 commented Mar 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Establish a proper branch-based development workflow: all changes via PRs, no direct pushes to master
  • Add conventional commit enforcement, PR template, changelog tooling, and CI hardening
  • Apply cargo fmt across the entire workspace to establish a clean baseline

Changes

  • CLAUDE.md: Add Development Workflow section (branching, commits, PRs, releases, pre-commit checks). Tracked in git now (removed from .gitignore).
  • .github/workflows/ci.yml: Add cargo fmt --check step, add PR title lint via amannn/action-semantic-pull-request
  • .github/pull_request_template.md: New template with Summary, Changes, Test plan, Notes sections
  • cliff.toml: git-cliff config for automated changelog generation from conventional commits
  • CONTRIBUTING.md: Updated with branch naming, conventional commit format, and new workflow
  • .gitignore: Remove CLAUDE.md entry
  • All crates: cargo fmt applied (62 files, formatting only)
  • Pre-commit hook: Installed locally for cargo fmt check

Test plan

  • cargo fmt --check passes
  • cargo build --workspace (pre-existing state, no logic changes)
  • CI runs on this PR (validates the new workflow)
  • PR title lint validates conventional commit format

Notes

  • Branch protection should be set up after this merges (requires admin API access)
  • The cargo fmt commit is large (62 files) but contains zero logic changes -- purely whitespace/formatting
  • Pre-commit hook is local only (.git/hooks/), not distributable via git. Contributors install it manually.

markm39 added 3 commits March 27, 2026 22:04
Apply rustfmt to all crates to establish a clean formatting baseline.
CI now enforces `cargo fmt --check` so this must pass before merge.
- Track CLAUDE.md in git (removed from .gitignore) so workflow rules are shared
- Add Development Workflow section to CLAUDE.md: branching, conventional commits,
  PR process, release process, pre-commit checks
- Add PR template with summary, changes, test plan sections
- Add git-cliff config (cliff.toml) for automated changelog generation
- Harden CI: add cargo fmt --check, add PR title lint via semantic-pull-request
- Update CONTRIBUTING.md with new branch and commit conventions
- Replace `is_some()` + `unwrap()` with `if let Some()` (goals.rs)
- Replace `!x.is_none()` with `x.is_some()` (search.rs)
- Replace `.max().min()` with `.clamp()` (cloud/lib.rs)
- Replace `push_str("\n")` with `push('\n')` (dashboard/lib.rs)
- Replace `drain(..).collect()` with `std::mem::take()` (ingest.rs)
- Replace `for row { if let Ok }` with `.flatten()` (corpus.rs)
- Collapse identical if/else-if blocks (autonomous_headless.rs, event_loop.rs)
- Add `Default` impl for `OllamaProposer` (ollama.rs)
- Add `#[allow(clippy::too_many_arguments)]` for upsert_item (embeddings.rs)
@markm39 markm39 merged commit 9693cd1 into master Mar 28, 2026
3 checks passed
@markm39 markm39 deleted the chore/dev-workflow branch March 28, 2026 03:14
markm39 added a commit that referenced this pull request Mar 28, 2026
* chore: cargo fmt across workspace

Apply rustfmt to all crates to establish a clean formatting baseline.
CI now enforces `cargo fmt --check` so this must pass before merge.

* chore: add enterprise dev workflow

- Track CLAUDE.md in git (removed from .gitignore) so workflow rules are shared
- Add Development Workflow section to CLAUDE.md: branching, conventional commits,
  PR process, release process, pre-commit checks
- Add PR template with summary, changes, test plan sections
- Add git-cliff config (cliff.toml) for automated changelog generation
- Harden CI: add cargo fmt --check, add PR title lint via semantic-pull-request
- Update CONTRIBUTING.md with new branch and commit conventions

* fix: resolve clippy warnings for Rust 1.94 CI compatibility

- Replace `is_some()` + `unwrap()` with `if let Some()` (goals.rs)
- Replace `!x.is_none()` with `x.is_some()` (search.rs)
- Replace `.max().min()` with `.clamp()` (cloud/lib.rs)
- Replace `push_str("\n")` with `push('\n')` (dashboard/lib.rs)
- Replace `drain(..).collect()` with `std::mem::take()` (ingest.rs)
- Replace `for row { if let Ok }` with `.flatten()` (corpus.rs)
- Collapse identical if/else-if blocks (autonomous_headless.rs, event_loop.rs)
- Add `Default` impl for `OllamaProposer` (ollama.rs)
- Add `#[allow(clippy::too_many_arguments)]` for upsert_item (embeddings.rs)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant