Conversation
- bumped compiler version to 9 - moved tests to JUnit 5
bowbahdoe
approved these changes
Aug 4, 2023
|
Woah thats wack - i can approve changes on a repo I don't own |
Author
|
The module is a now packaged into a multi-release jar: Java 1.7+ or Java 9+. I find it impossible to include Java 1.6, it seems not supported anymore by Maven and/or the latest JDK. Actually, the original main branch of this project does not build with maven on my machine exactly because Java 1.6 is not supported. Anyone able to improve the pom.xml in order to include Java 1.6? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made the code into a Java 9 module. This required to:
All tests pass.