Conversation
Agent-Logs-Url: https://github.com/mvrl/QuARI/sessions/22c88cba-d21a-4b84-b08e-560fa0978893 Co-authored-by: jacobsn <984784+jacobsn@users.noreply.github.com>
|
@copilot can you check to see if this PR addresses #1 (including factoring in the comments). Is there anything else we should do before merging this? Perhaps we need to have more detailed instructions for how to download the other datasets and specific command lines for running smoke tests and replication. |
Agent-Logs-Url: https://github.com/mvrl/QuARI/sessions/808f0a3d-b601-4ca0-bb4e-30b6dcbf39eb Co-authored-by: jacobsn <984784+jacobsn@users.noreply.github.com>
This PR does address issue #1 — the core workflow bugs (hardcoded paths in To close the remaining gaps (download instructions, specific model names, runnable replication), I've added in commit 9430b98:
One thing worth confirming with @EricX003: the HuggingFace dataset repo IDs I've used ( Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot resolve merge conflicts and make sure sure this PR "makes sense" |
…e_ids support and distractor loader fix Co-authored-by: jacobsn <984784+jacobsn@users.noreply.github.com>
Resolved in commit 6ff6786. The only conflict was in |
Users had no clear path to evaluate on ILIAS/INQUIRE:
compute_embeds.pyhad hardcoded researcher-specific paths,eval_retrieval.pysilently broke when loading distractor embeddings due to a key mismatch, there was no way to test the pipeline without downloading large datasets, and there were no download scripts or replication commands for the evaluation benchmarks.compute_embeds.py— remove hardcoded paths--shard_dirand--out_dirare now required CLI arguments (were hardcoded to/u/ericx003/data/ilias/yfcc100mand./yfcc_embeds)eval_retrieval.py— fix distractor loading and add baseline-only modecompute_embeds.pywrites{"keys": ..., "embeddings": ...}but the distractor loader calleddata['image_embeddings'], causing aKeyErrorat eval time.Added
load_distractor_embeddings_from_dir()that accepts both formats:Explicit
.float()cast on distractor tensors sincecompute_embeds.pydefaults to fp16 storage.Added
--baseline_onlyflag that skips model loading entirely, so the full data pipeline can be smoke-tested without downloading any pretrained checkpoint.--checkpoint_pathis now optional and only required when--baseline_onlyis not set.create_sample_dataset.py— new synthetic data generatorGenerates minimal WebDataset tar shards for smoke-testing the pipeline end-to-end without large downloads:
downloading/download_ilias.pyanddownloading/download_inquire.py— new dataset download scriptsTwo new download scripts following the same
snapshot_downloadpattern as the existingdownload_cc12m.py:download_ilias.pypulls ILIAS-core query shards fromMVRL/ILIASon HuggingFace and prints the next-stepprecompute_embeddings.pycommand. Includes notes on obtaining the separate YFCC15M distractor images.download_inquire.pypulls INQUIRE query annotations fromolivialiu/INQUIREon HuggingFace. Includes notes on obtaining the iNaturalist 2021 distractor images.README.md— evaluation documentationsiglip2-large-patch16-512, the model confirmed to reproduce paper results) and INQUIRE.--baseline_onlyand requires no pretrained checkpoint to run end-to-end.