fix: a year finding needs a year CrossRef actually holds (0.6.2) - #30
Merged
Merged
Conversation
Two of three one-year Tier B findings on published reference lists were against correct citations. Neither was a matching problem: CrossRef holds only the 2006 online date for Benton & Donoghue (printed in the 2007 volume), and "Biocomputing 2001" was printed in December 2000. Both are visible in the record, so the year directly after an online-only date, and a year that names the container, are now Tier C. A record with both dates still fails a year that is one off. Also reads `years` back from the cache. It was written and never read, so an online-first paper cited by its print year failed on every cached run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Answers the open question of whether one-year Tier B findings on search-matched entries should fail CI. They should, when the record can support the claim. The false ones were not caused by the search match.
On three published reference lists 0.6.1 raised three one-year year findings. Two were against correct citations:
Both are readable from the record, so the year directly after an online-only date, and a year that names the container, become Tier C. Phillips et al. (PNAS 106, online and print both 2009, cited as 2010) stays Tier B.
Cost, stated in the changelog: an online-only journal also has no print date, so a citation one year late to such a journal drops from a failure to a note.
Also fixes the cache, which wrote
yearsand never read it back. An online-first paper cited by its print year passed on the first run and failed on every cached run.Verification
tests/data/crossref_years/.+1to+2, dropping the no-print-date condition, droppingyearsfrom the cache read, dropping the digit boundary on the container match.Bumps 0.6.2 including the Action pin, so tag after merge.