fix: no-DOI entries were judged against the wrong paper (0.6.1) - #29
Merged
Merged
Conversation
0.6.0 accepted CrossRef's first hit unconditionally and compared the byline against it: 59 false author mismatches on three published reference lists. Query with the whole printed reference, accept a hit only on title plus byline-membership evidence, and report the rest as Tier U with the closest match. Also fixes three reference-splitting errors found on the same files. Releases 0.6.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.6.0 accepted CrossRef's first search hit for any entry without a DOI and compared the byline against it. On real reference lists most of those hits are a different paper.
All 59 Tier A findings on the three published lists were false. The residual U rows are books, software manuals and the editor byline; the B rows are one-year online/print differences.
search_hit_is_cited_work: title evidence + cited author somewhere in the byline (+ year when the verdict would be author order); otherwise Tier U naming the closest matchEvery new test was seen failing on the old code; the author-order Tier A test passes before and after. Bumps to 0.6.1 (incl. the Action pin); tag
v0.6.1after merge.