Repository navigation
fix(accounts): distinguish Codex Team members - #158
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Different members of the same ChatGPT Team share a workspace account ID. SubLane previously used that ID alone for deduplication, rejecting the second member and allowing another member to replace an existing account's credentials.
Use a workspace/member identity key while preserving the original workspace ID for upstream requests. Duplicate checks stay inside the mutation transaction and inspect only the relevant upstream workspace, including legacy keys and comparable JWT claims. Reauthorization and refresh reject conflicting member claims and loss of a known canonical user ID.
The PR also includes the versioned v0.19.2 changelog, generated with git-cliff 2.14.2. Changelog validation passed all four tests. The release tag will be created after CI passes and this PR is merged.
Related issues
Closes #157
Validation
make checkpassed: sqlc generation check, Go vet/format checks, frontend type/lint/format checks, script tests (134 passed, 5 conditional skips), the full Go race suite, 544 frontend tests, and the production build.go test ./...passed.go test ./internal/accounts ./internal/backup ./internal/upstream -count=1passed.Compatibility and migration
No schema migration or account recreation is required. Existing encrypted credentials and workspace-only database keys remain readable. Credential rotation upgrades the stored deduplication key without changing local account IDs, resource-group assignments, or conversation bindings. Imports lacking comparable member identity retain conservative workspace-level duplicate protection.
Older binaries cannot read the new member-aware keys. Restore a pre-upgrade backup before downgrading.
Checklist