chore: drop unused thiserror and tower dependencies - #1
Open
usehoplite[bot] wants to merge 1 commit into
Open
Conversation
thiserror and tower are declared in Cargo.toml but never referenced in source. Remove them, regenerate the lockfile, and normalize the two imports rustfmt flags so the CI fmt check passes. Co-authored-by: ship fast <buildfastapps@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audited every direct dependency in
Cargo.tomlagainst the source tree and removed the two that are provably unused:thiserror(2.0) — zero references insrc/(repo-wide grep forthiserrormatches onlyCargo.toml). The crate stays inCargo.lockonly as a transitive dependency of other crates.tower(0.5) — zero references insrc/; it only appeared as an optional dep activated by thehttpfeature. Thehttpfeature is simplified to["dep:axum"].towerremains in the lockfile as axum's own transitive dependency.The regenerated
Cargo.lockis minimal: exactly the two direct-dep edges forcloud-toolswere removed, with no version drift for any other package.All 18 remaining direct dependencies (tokio, reqwest, serde/serde_json, anyhow, tracing(-subscriber), rmcp, hmac/sha1/sha2/hex, jsonwebtoken, chrono, urlencoding, axum, quick-xml, futures) have real source references and were kept.
While running the CI validation chain,
cargo fmt --checkflagged two pre-existing import-order issues insrc/clouds/aws/cloudwatch_logs.rsandsrc/clouds/aws/ec2.rs(confirmed to fail at HEAD before this change). They were normalized withcargo fmtso the repo's own CI gate passes.Verification
Ran the same chain as the
checkjob in.github/workflows/ci.yml, with Rust 1.98.0 stable:cargo fmt --all --check— passcargo clippy --all-targets --all-features -- -D warnings— passcargo test --all-features— 20 passed, 0 failedcargo build --release --locked --all-features— pass (lockfile consistent with trimmed manifest)The npm wrapper (
npm/package.json) declares zero dependencies and its scripts only use Node built-ins — nothing to audit on that side.