fix(desktop): hold loading until pre-workspace overlay opens#3424
Open
marovole wants to merge 1 commit into
Open
fix(desktop): hold loading until pre-workspace overlay opens#3424marovole wants to merge 1 commit into
marovole wants to merge 1 commit into
Conversation
Authenticated users entering onboarding, invitations, or create-workspace flows saw a blank window: DesktopShell mounted before the window overlay useEffect ran (and before listMyInvitations resolved), leaving TabContent and WindowOverlay both null. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@marovole is attempting to deploy a commit to the IndexLabs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DesktopShellrendered before the window overlayuseEffectran (and beforelistMyInvitations()resolved), leavingTabContentandWindowOverlaybothnull.Test plan
onboarded_atnull: app shows loading briefly, then onboarding or invitations overlay (no blank window).Made with Cursor