Repository navigation
fix(mcp): preserve complete input schemas - #86
Merged
Merged
Conversation
The restricted schema conversion drops defaults, compositions, and root keywords. Preserve the official MCP SDK schema as raw JSON instead of rebuilding it through LangChainGo definitions. Keep the deprecated normalization helper for existing callers, but remove it from discovery. Replace the invented-properties test with lossless discovery regressions. Check OpenAI and LocalAI HTTP serialization for completion and streaming requests.
mudler
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve the official MCP SDK's complete
Tool.InputSchemaasjson.RawMessagewhen constructing model-facing tool parameters.The previous conversion through LangChainGo's
jsonschema.Definitionloses keywords that the struct cannot represent. For example, a nullable enum expressed withanyOfbecomes{"properties":{}}. Its enum and default disappear. Root references, definitions, and compositions can disappear too.MCP discovery now forwards the schema without that conversion or nullable/boolean coercion. The exported
CoerceNullableTypeshelper remains available, deprecated and isolated from discovery, for existing callers.Tests
Verification commands (all pass):
The corrected regression tests fail before the implementation. Independent review and a separate non-e2e test run pass.
Scope
No dependency upgrade or broader LLM migration. The default MCP path preserves schemas; opt-in strict-tool mode retains its existing transformations. HTTP tests use local mock servers, not external model services.