fix(gallery): add fallback URI resolution for backend installation#8663
Merged
mudler merged 2 commits intomudler:masterfrom Feb 27, 2026
Merged
Conversation
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
When a backend installation fails (e.g., due to missing 'latest-' tag), try fallback URIs in order: 1. Replace 'latest-' with 'master-' in the URI 2. If that fails, append '-development' to the backend name This fixes the issue where backend index entries don't match the repository tags. For example, installing 'ace-step' tries to download 'latest-gpu-nvidia-cuda-13-ace-step' but only 'master-gpu-nvidia-cuda-13-ace-step' exists in the quay.io registry. Fixes: mudler#8437 Signed-off-by: localai-bot <139863280+localai-bot@users.noreply.github.com>
825e85d to
fc5bce5
Compare
mudler
reviewed
Feb 27, 2026
core/gallery/backends.go
Outdated
| } | ||
|
|
||
| // Try fallback: replace "latest-" with "master-" in the URI | ||
| fallbackURI := strings.Replace(string(config.URI), "latest-", "master-", 1) |
Owner
There was a problem hiding this comment.
let's make these ("latest" and "master") optional environment variable
mudler
reviewed
Feb 27, 2026
core/gallery/backends.go
Outdated
| } else { | ||
| // Try another fallback: add "-development" suffix to the backend name | ||
| // For example: master-gpu-nvidia-cuda-13-ace-step -> master-gpu-nvidia-cuda-13-ace-step-development | ||
| if !strings.Contains(fallbackURI, "-development") { |
Owner
There was a problem hiding this comment.
also "development" , better be env variables that can be optionally tweaked if really necessary
mudler
approved these changes
Feb 27, 2026
Owner
mudler
left a comment
There was a problem hiding this comment.
I'm ok with it temporarly now.
But you should do a follow-up to set the environment variables in core/cli/run.go where all the others are already defined, and propagate these as AppOption and pass the application to InstallBackend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a backend installation fails (e.g., due to missing 'latest-' tag), try fallback URIs in order:
This fixes the issue where backend index entries don't match the repository tags. For example, installing 'ace-step' tries to download 'latest-gpu-nvidia-cuda-13-ace-step' but only 'master-gpu-nvidia-cuda-13-ace-step' exists in the quay.io registry.
Fixes: #8437