Conversation
- Added `CastlingRights` type and field to `Game` struct. - Updated `NewGame` to parse castling rights and side to move from FEN string. - Implemented `IsAttacked` helper method to check if a square is under attack. - Implemented castling logic in `GenerateMoves` for both White and Black, ensuring: - Castling rights are available. - Path between King and Rook is empty. - King is not in check, does not pass through check, and does not land in check. - Fixed existing build errors in `types.go` related to `int8` to `string` conversion. - Added comprehensive tests in `types_test.go` covering various castling scenarios. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Implemented castling rules for the toyfish chess engine. This includes parsing castling availability from FEN strings, adding a
CastlingRightsbitmask to the game state, and implementing the move generation logic to support King-side and Queen-side castling for both colors. The implementation includes safety checks to ensure the King cannot castle out of, through, or into check, and that the path is clear of pieces. Also fixed some existing build warnings/errors intypes.go.PR created automatically by Jules for task 11075299703710597085 started by @aaylward