fix(one_d4): delete occurrences before re-inserting in flushBatch#1145
Merged
fix(one_d4): delete occurrences before re-inserting in flushBatch#1145
Conversation
Re-indexing a partial month would accumulate duplicate motif_occurrences rows for previously-indexed games because insertOccurrencesBatch used a plain INSERT with no conflict protection. The fix mirrors what the admin reanalyze endpoint already did correctly: delete existing occurrences for each game_url before inserting fresh ones. Adds a regression test that verifies delete-then-reinsert produces exactly one occurrence row, not two.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
1d4-web | 4740992 | Commit Preview URL Branch Preview URL |
Apr 08 2026, 04:59 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
motif_occurrencesrows for previously-indexed games:insertOccurrencesBatchused a plainINSERTwith no conflict protection, and theON DELETE CASCADEongame_featuresnever fired because the upsert updates the row rather than deleting itflushBatchnow callsdeleteOccurrencesByGameUrlsbeforeinsertOccurrencesBatch, mirroring what the admin/reanalyzeendpoint already did correctlyTest plan
bazel test //domains/games/apis/one_d4/...— 35/35 passdeleteOccurrencesByGameUrls_thenReinsert_doesNotDuplicateinGameFeatureDaoTestcovers the regression