Skip to content

Bestow is greyed at 0 BP but has no confirm twin: committing it still eats the turn #232

Description

@mtklein

Found while landing the MP confirm gate (the merge above), and deliberately left out of it — same shape, different currency.

Ot6BushidoRowGrey greys the thief submenu's Bestow row when the caster has 0 BP, but there is no refusal at the confirm. Ot6Bestow still refuses at execution, so a player who commits the greyed row loses the turn with no feedback — exactly the defect just fixed for MP.

The MP gate now covers Blitz, Tools, SwdTech, Steal and Dance. SwdTech's BP reason already has its confirm twin in Ot6BushidoConfirm. Bestow is the one greyed row left whose grey is advice rather than a rule.

The mechanism to copy is now in place: Ot6ConfirmVerdict in ff6/src/battle/ot6_cmdmenu.asm takes a row's price from the same leaf that drew it and its verdict from the same grey the row's colour took. Bestow needs the BP equivalent, alongside the MP one, on the same call site.

Small, and it makes "a greyed row cannot be committed" true without exception rather than true for four of five reasons.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions