gtk4: Update to 4.20.3#25319
Conversation
media backend modules got removed upstream and gstreamer is always linked now
|
Hi, I tested
Video player is not working though. I've never used the video player personally, so I don't know which commit is the most recent good one in order to do a Information displayed in Inspector's "Global" tabGeneral Information
Application
Environment
Display
Monitors
Seats
OpenGL
Vulkan
|
|
The rendering issues are with opengl and d3d. But good to know that cairo works fine. |
|
I remember GTK with #if defined(G_OS_WIN32)
if (g_getenv("GSK_RENDERER") == NULL)
{
g_setenv("GSK_RENDERER", "cairo");
}
#endif |
|
The PR should be merged, because the D3DRenderer will not port to the old version. Or skip this version, move to GTK 4.24 directly. |
|
@lazka GTK 4.20.3 is released. |
There was a problem hiding this comment.
It looks like this patch was upstreamed via commit https://gitlab.gnome.org/GNOME/gtk/-/commit/f071763fd69e8924c497b9b21e43ef8e80718eff. MR https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/9185 will likely backport this to 4.20.x.
|
Hi again, this PR should be merged, gvsbuild repository already updated to gtk 4.20.3 and fixed the problems with the shadows (allegedly), maybe we could bring those changes to here. |
|
ok, I'll have a look tomorrow. |
|
Actually I referenced the changes that were already here to disable dcomp. I also opened https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/9185 to bring in the cairo fix upstream. I'm not sure what the video rendering problem is that was referenced. |
|
If we merge this then some video rendering will be broken (see gtk4-widget-factory), though I don't know if there are many users using video rendering in gtk like this. On the other hand we are more closely following upstream. I'm fine with merging, if there are no objections. |
|
All seems alright, tested both GL and Cairo and both rendered good, couldn't test Vulkan because didn't have the hardware, but I think it should work as well. For context, GTK Windows apps with gtk 4.18 (and previous versions) using GL renderer looked like this, I don't exactly have a Windows screenshot, but looked exactly like this. (See this issue)
|
|
I found that the video player problem dates back to September 2024, see the image attached to the comment. https://gitlab.gnome.org/GNOME/gtk/-/issues/6721#note_2215021 No issue has been reported upstream in that timespan, so I think it is fine to merge this and hope that this will be resolved in the future. |
|
I've built the GTK 4.20.3 package on windows 25H2 with MSYS2, it works fine. |



media backend modules got removed upstream and gstreamer is always linked now
rendering is broken, so can't be merged.
GDK_DISABLE=dcompfixes some of it. video rending is broken stilltheora BBB video is also broken, but h264 works.