Skip to content

chore: drop cache in setup-node#2745

Merged
kettanaito merged 2 commits into
mainfrom
chore/drop-cache-in-ci
May 12, 2026
Merged

chore: drop cache in setup-node#2745
kettanaito merged 2 commits into
mainfrom
chore/drop-cache-in-ci

Conversation

@kettanaito

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented May 12, 2026

Copy link
Copy Markdown

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 621cffec-ff82-4768-b087-bac0324108ab

📥 Commits

Reviewing files that changed from the base of the PR and between a2de709 and f5f6f31.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • .github/workflows/release.yml
💤 Files with no reviewable changes (2)
  • .github/workflows/release.yml
  • .github/workflows/ci.yml

📝 Walkthrough

Walkthrough

The PR removes the cache: 'pnpm' setting from actions/setup-node@v4 across all CI jobs and the release workflow, while also pinning specific Node versions (22 and 24) in the release workflow's build and release jobs respectively.

Changes

Workflow Node setup updates

Layer / File(s) Summary
CI workflow cache removal
.github/workflows/ci.yml
Removes cache: 'pnpm' from the Node.js setup action across eight jobs: build-20, build-22, test-unit, test-node-20, test-node-22, test-e2e, test-browser, and test-native.
Release workflow cache removal and version pinning
.github/workflows/release.yml
Removes cache: 'pnpm' from Node.js setup and adds explicit Node versions: 22 for the build job and 24 for the release job (with comment noting Trusted Publishing requirement).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A cache less taken, the workflows run clean,
Node versions pinned, predictable and keen,
Eight jobs aligned in the CI's bright glow,
Release flows steady with twenty-four's show,
Hop to the finish, configurations flow!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided by the author, making it impossible to assess relevance to the changeset. Provide a brief description explaining why the cache setting was removed from setup-node (e.g., performance, caching strategy changes, or build stability).
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title directly describes the main change: removing the cache setting from the setup-node action configuration in CI/release workflows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/drop-cache-in-ci

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-new Bot commented May 12, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/msw@2745

commit: 9a63b38

@kettanaito
kettanaito merged commit f76d5f3 into main May 12, 2026
24 checks passed
@kettanaito
kettanaito deleted the chore/drop-cache-in-ci branch May 12, 2026 12:43
@kettanaito

Copy link
Copy Markdown
Member Author

Released: v2.14.7 🎉

This has been released in v2.14.7.

Get these changes by running the following command:

npm i msw@latest

Predictable release automation by Release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant