Skip to content

chore: remove miniflare dependency and tests#2744

Merged
kettanaito merged 1 commit into
mainfrom
chore/remove-miniflare
May 12, 2026
Merged

chore: remove miniflare dependency and tests#2744
kettanaito merged 1 commit into
mainfrom
chore/remove-miniflare

Conversation

@kettanaito

@kettanaito kettanaito commented May 12, 2026

Copy link
Copy Markdown
Member

The miniflare Vitest environment is deprecated by Cloudflare. We now have @msw/cloudflare in the works that acts as the test suite for MSW support in that environment.

@coderabbitai

coderabbitai Bot commented May 12, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: cb3f3a8f-5caf-4a27-bc2a-a31eff99be68

📥 Commits

Reviewing files that changed from the base of the PR and between a2de709 and b9bedd5.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • package.json
  • test/node/regressions/miniflare.node.test.ts
💤 Files with no reviewable changes (2)
  • test/node/regressions/miniflare.node.test.ts
  • package.json

📝 Walkthrough

Walkthrough

Removal of Miniflare testing environment setup, including the vitest-environment-miniflare dev dependency and the associated regression test file that validated HTTP server behavior using that environment.

Changes

Miniflare Test Environment Removal

Layer / File(s) Summary
Dependency and test cleanup
package.json, test/node/regressions/miniflare.node.test.ts
Dev dependency vitest-environment-miniflare@^2.14.4 is removed from package.json. The corresponding test file containing Miniflare environment setup, HTTP server configuration, MSW mock handlers, and Node http.get/http.request regression tests is deleted entirely.

Estimated Code Review Effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A miniflare once danced in our test,
But its time has come, it needed rest.
Dev dependencies trimmed with care,
Cleaner lockfiles fill the air!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: remove miniflare dependency and tests' clearly and accurately summarizes the main changes: removing the vitest-environment-miniflare dependency and the associated test file.
Description check ✅ Passed The description provides relevant context about why miniflare is being removed (deprecated by Cloudflare) and mentions the replacement solution (@msw/cloudflare), directly relating to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-miniflare

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kettanaito
kettanaito merged commit d2ced69 into main May 12, 2026
24 checks passed
@kettanaito
kettanaito deleted the chore/remove-miniflare branch May 12, 2026 12:31
@kettanaito

Copy link
Copy Markdown
Member Author

Released: v2.14.7 🎉

This has been released in v2.14.7.

Get these changes by running the following command:

npm i msw@latest

Predictable release automation by Release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant