Repository navigation
Flows cleanup: remove unused speculator resolvers; plan matches the Commercial strip - #54
Merged
Merged
Conversation
The /analysis panel dropped the Speculator line for a Legacy Commercial flow strip (cot-analyzer #144), so these have no caller in cotmetrics, cot-analyzer, npf or livebook: flows.speculator_net, retail_net, speculator_frame, net_col, index_col and _summed_net, CotIndexer.get_speculator_data, and the constants SPECULATOR, RETAIL and NET_SUFFIX. None was ever released (0.15.x is untagged), so there is no deprecation path to keep. Kept: weekly_change, flow_z, leg_flow_frame, get_commercial_flow_data, and the FlowRoles table, which the panel's retail label reads; its generated docstring now says so. The module docstring now describes the one strip it serves. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Top, section 3, decisions, hazards, render checks and the don'ts now describe the Legacy Commercial weekly flow strip on /analysis (cotmetrics #52, #53 and this PR; cot-analyzer #142 and #144), why it replaced v2's speculator series, the Speculator line in the withdrawn record, and the Treasury question answered (they stay out of the COT-gated books). Section 2 unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits, after mspinola/cot-analyzer#144 replaced the Speculator line with a Legacy Commercial flow strip.
1. Remove the speculator resolvers nothing reads.
flows.speculator_net,retail_net,speculator_frame,net_col,index_col,_summed_net,CotIndexer.get_speculator_data, and the constantsSPECULATOR,RETAIL,NET_SUFFIX. Searched cotmetrics, cot-analyzer, npf and livebook: no caller. Never released (0.15.x is untagged), so no deprecation path. Kept:weekly_change,flow_z,leg_flow_frame,get_commercial_flow_data, and theFlowRolestable (the panel's retail label reads it; its generated docstring now says so, andgen_flow_roles.py --checkpasses). Version stays 0.15.1: nothing the analyzer's floor names is removed.2. Plan doc matches what shipped.
docs/design/cot-flows.md: the top, section 3, decisions, hazards, render checks and "what not to do" describe the Commercial strip, why it replaced v2's speculator series, the Speculator line in the withdrawn record, and the Treasury question (they stay out of the COT-gated books). Section 2's measurements unchanged.Verification: store-free suite 513 passed, 3 skipped (521 before, less the eight tests of removed code); ruff clean; cot-analyzer's suite against this tree to be run with the local env refresh.
🤖 Generated with Claude Code