Repository navigation
Read max pain from the stored real strike, not the grid argmin (0.14.1) - #46
Merged
Merged
Conversation
`get_max_pain_for_symbol`, which feeds the heatmap's Max Pain Pull, took the argmin of the 200-point simulated curve and never read `MaxPainStrike`, the curve's minimum already snapped to a strike the chain has. The argmin can sit up to half a grid step off any real strike, so the heatmap's pull was measured against a different strike from the star the analysis panels draw (those were moved onto the stored strike in cot-analyzer#134). Both payouts are now read off the curve by interpolation at the exact prices rather than the nearest grid point. Snapshots written before the column existed fall back to the grid argmin. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the residual noted in mspinola/cot-analyzer#134.
get_max_pain_for_symbol, which feeds the heatmap's Max Pain Pull, took the argmin of the 200-point simulated curve and never readMaxPainStrike, the curve's minimum already snapped to a real strike by the writer. The argmin can sit up to half a grid step off any real strike, so the heatmap's pull was measured against a different strike from the star the analysis panels now draw. Both payouts (at max pain and at the current price) are read off the curve by interpolation at the exact prices rather than the nearest grid point. Snapshots without the column fall back to the grid argmin.Two tests added to
tests/test_options_cache.py; suite 474 passed, 2 skipped; ruff 0.15.22 clean.🤖 Generated with Claude Code