feat(vintage): revision marker file + alert selftest - #79
Merged
Merged
Conversation
…es it fires Task Scheduler's own 'Send an e-mail' / 'Display a message' actions are DEPRECATED and non-functional on Windows 8 / Server 2012+, so a non-zero exit alone is only a passive Last Run Result 0x1 that someone has to go and look at. An earlier comment in this file implied otherwise; corrected. run-vintage.cmd now notifies itself. On any run that records a revision it appends that run's output to <store>\vintage\REVISIONS_<yyyy-MM-dd>.txt, which rides the existing robocopy /MIR push to the Mac, so the alert lands on the machine the work happens on. - The marker is written IMMEDIATELY after ingest, not at the end: the revision is already committed at that point, so a later unrelated failure must not be able to suppress it. - Appends rather than overwrites, so two revision runs in one day both survive. - Date comes from PowerShell, not %DATE%, which is formatted per regional settings and is not safe in a filename. - Ingest output goes to a .tmp scratch file so the marker holds only THIS run rather than the whole appended history, and the existing *.tmp sync exclusions skip it. scripts/vintage_alert_selftest.py forces a revision in a throwaway store and drives the real CLI, so the loud path can be verified now rather than trusted until CFTC eventually restates something. An alert nobody has watched fire is one nobody should rely on. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #78, closing the notification gap.
Task Scheduler's built-in
Send an e-mail/Display a messageactions are deprecated and non-functional on Windows 8 / Server 2012+, soingestexiting non-zero only produced a passiveLast Run Result 0x1that someone had to go and look at. A comment inrun-vintage.cmdimplied Task Scheduler could alert on it; that was wrong and is corrected.The script now notifies itself. On any run that records a revision it appends that run's output to
<store>\vintage\REVISIONS_<yyyy-MM-dd>.txt, which rides the existingrobocopy /MIRpush to the Mac.%DATE%, which is locale-formatted and unsafe in a filename..tmpscratch file, so the marker holds only that run and the existing*.tmpsync exclusions skip it.scripts/vintage_alert_selftest.pyforces a revision in a throwaway store and drives the real CLI, so the loud path can be seen working now instead of being trusted until CFTC eventually restates something.201 tests pass, ruff clean.
🤖 Generated with Claude Code