Fix stale databento.py docstring; derive _DATABENTO_UNSUPPORTED from registry - #75
Merged
Merged
Conversation
…the registry The module docstring still said "DORMANT. NOT in the live EOD path", but the file now hosts the live ADR-0006 two-stage producer (ingest/build) that update.py drives. Rewrote it to describe both parts: the LIVE producer (databento as a validated alternative to Norgate) and the genuinely dormant older EOD helpers kept for the intraday work. _DATABENTO_UNSUPPORTED was a hardcoded set (CC/OJ/SB/KC/LBR/CT) that duplicated and had drifted from the registry's authoritative `databento: null` mapping (it missed DX, MME, MFS). Derive it from the registry so it can't go stale. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small cleanups left over from the databento arc.
Docstring.
providers/databento.pystill opened with "DORMANT. NOT in the live EOD path (Norgate replaced it)" — false since ADR-0006, as the file now hosts the liveingest/buildproducer thatupdate.pydrives. Rewritten to describe both parts: the LIVE two-stage producer (databento as a validated alternative to Norgate) and the genuinely DORMANT older EOD helpers retained for the intraday work._DATABENTO_UNSUPPORTED. Was a hardcoded set{CC, OJ, SB, KC, LBR, CT}duplicating the registry's authoritativedatabento: nullmapping, and it had drifted (missed DX, MME, MFS). Now derived from the registry so it can't go stale. Verified import-safe withCOTDATA_STOREunset.54 databento/registry tests pass, ruff clean. No behavior change on the live path.
🤖 Generated with Claude Code