Repository navigation
Deprecate push_data_cache_to_server.sh; the Windows box pushes everything - #16
Merged
Merged
Conversation
…hing It pushed from the MAC, which cotdata/docs/SYNCING.md documents as a read-only replica rather than a producer. One Windows server produces everything and feeds two replicas, the Mac over SMB and the dash server over SSH, so this was a replica pushing to a replica and whichever side synced second won silently. Deprecated rather than deleted, per the maintainers call and for a reason: this file is referenced in four places in server-side/README.md, and a reader following an obsolete-but-present script that PRINTS its replacement fails more loudly than one following a dangling reference. It now exits 2 unless CROWDMON_ALLOW_LEGACY_PUSH=1. The crowdmon damage panel briefly rode here as an optional fourth payload (#14). That was DEAD CODE: wired into a script that does not run, so the panel had no path to the server at all. Removed here; it now ships via crowdmon/docs/examples/windows/push-panel.cmd, a Windows template modelled on cotdatas push-to-server.cmd. CROWDMON_STORE is a separate store root, so no exclusion-list change to cotdatas push could have carried it. #15, merged an hour ago, told people to run this script from the Windows box. That was wrong: it is not run-it-elsewhere, it is do-not-run-it. Corrected. server-side/README.md section 6 rewritten around the two Windows templates, and the stale data_cache push removed from the release-day block. data_cache and cot_data.db are pushed by nothing: PR #12 moved them to .local-state/cot-analyzer/ and the server rebuilds the cache. If that turns out to be wrong the fix is a third Windows template, not a revival of this script. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to mspinola/crowdmon#68, which adds the Windows templates that replace the panel half of this.
The script pushed from the wrong machine
scripts/push_data_cache_to_server.shpushes from the Mac.cotdata/docs/SYNCING.mddocuments the Mac as a read-only replica: one Windows server produces everything and feeds two replicas — the Mac over SMB (robocopy /MIR,sync-store.cmd) and this dash server over SSH (rsync,push-to-server.cmd).So this was a replica pushing to a replica, and as that doc puts it about two-producer topologies, whichever side syncs second wins silently.
It had also been unable to run since PR #12 routed runtime state out of the repo: the preflight still demanded
./data/cot_data.db, which moved to.local-state/cot-analyzer/, so it exited 1. The stale./data_cachewas the quieter half — a Jul 28 copy that would have been rsynced over the server's without comment had the preflight passed. Both are symptoms of a script nobody had run in a while, not bugs to fix. I reported them as fixable a few hours ago, which was the wrong read.Deprecated, not deleted, and it refuses
Kept because
server-side/README.mdreferenced it in four places. A reader who finds an obsolete-but-present script that prints its own replacement fails more loudly than one following a dangling reference.It now exits 2 with a message naming what replaces each payload, unless
CROWDMON_ALLOW_LEGACY_PUSH=1.cotdata/docs/examples/windows/push-to-server.cmdcrowdmon/docs/examples/windows/push-panel.cmddata_cache/,cot_data.dbThe dead fourth payload is gone
The crowdmon panel rode here as an optional fourth payload in #14. That was dead code — wired into a script that does not run, so the panel had no path to the server at all. Removed.
CROWDMON_STOREis a separate store root, so no exclusion-list change to cotdata's push could have carried it either; it needed its own Windows template, which is crowdmon#68.#15, merged an hour before this, told people to run this script from the Windows box. That was wrong — it is not run it elsewhere, it is do not run it. Corrected here.
What I did not settle
data_cache/andcot_data.dbare now pushed by nothing. PR #12 moved them to.local-state/cot-analyzer/, so the deprecated script could not have shipped them regardless, and the server has presumably been rebuilding the cache on its own for however long that has been true.server-side/README.mdnow says the server regenerates it, and says explicitly that if that turns out to be wrong, the fix is a third Windows-side template rather than a revival of this script.I am flagging rather than asserting: I cannot see the server, and "it has evidently been fine" is weaker evidence than someone who knows the deployment saying so.
server-side/README.md§6 is rewritten around the two Windows templates, and the staledata_cachepush is removed from the release-day block in §9.Testing
170 passed.ruffclean.bash -nclean, and the script exits 2 as intended.🤖 Generated with Claude Code