Repository navigation
Model titles through the gate display alias: 3-leg / 2-leg, not CLS / CS - #133
Merged
Merged
Conversation
The three places that spelled the books' gate notation themselves (MODEL_LABELS for Raw PF, the heatmap Setups tooltip, the About workflow) now take it from the model title or gate_label, so screens read "Raw PF 3-leg 95/5" and "NPF 2-leg 80/20". Pairs with cotmetrics' gate_label alias; gate itself is unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #131 / #132. The model titles still carried the books' gate notation (Raw CLS 95/5, NPF CS 80/20), which spells the legs by the CMR initials. With cotmetrics'
gate_labelalias the titles read Raw 3-leg 95/5 / NPF 2-leg 80/20 / NPF 3-leg 95/5, and the three places here that spelled the notation themselves (MODEL_LABELSfor Raw PF, the heatmap Setups tooltip, the About workflow) now take it from the model or the alias.gateis untouched on the model; it is the books' pre-registered spec name.Depends on mspinola/cotmetrics PR "Gate display alias: 3-leg / 2-leg titles, CLS / CS kept as the spec name". Merge that first.
Test plan
pytest tests -q(CI env): 875 passedruff check src tests: clean🤖 Generated with Claude Code